Make deadline extensions consider daylight savings time #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, if a teacher gives a 7-day extension to a Wed 6pm deadline from late October to early November, the student will be able to submit until Wed 6pm the following week instead of 5pm, like previously. Fixes apluslms#1287
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What?
For example, if a teacher gives a 7-day extension to a Wed 6pm deadline from late October to early November, the student will be able to submit until Wed 6pm the following week instead of 5pm, like previously.
Testing
Tested that the deviations work as expected using a docker image ihalaij1/run-aplus-front:faketime that allows changing of the internal time.
docker-compose.yml:
Fixes #1287