Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News in multiple languages #1350

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Conversation

mikaelGusse
Copy link
Contributor

@mikaelGusse mikaelGusse commented Mar 19, 2024

Description

What?

demo_comp2.mp4

Adds the option to create news items in a specific language while preserving the possibility to create news items that are visible for everyone.

Why?

Suggested by teachers and further facilitates easier management of multilingual courses.

How?

Added a datapoint to the news model for language and updated the news creation form to allow the user to choose the language of the object.

Fixes #1134

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

Went into the views where the news were visible and made sure everything worked.

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

@ihalaij1 ihalaij1 requested a review from murhum1 March 19, 2024 12:20
@mikaelGusse mikaelGusse marked this pull request as ready for review March 20, 2024 07:43
@mikaelGusse mikaelGusse force-pushed the news_languages branch 2 times, most recently from 2da710f to 6c3ac4f Compare March 20, 2024 07:50
@murhum1 murhum1 merged commit 9e56353 into apluslms:master Mar 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Improve UI for creating multilingual news items
2 participants