Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login should not take the user to the front page #1352

Merged
merged 1 commit into from
May 6, 2024

Conversation

khattam2
Copy link
Collaborator

Fixes #1133

Description

What?

Login should not take the user to the front page.

Why?

The user should be redirected to the same page they came from after login.

How?

The user is now being taken to the page it came from before logging in.

Testing

image
image

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

@murhum1 murhum1 self-assigned this Apr 19, 2024
@murhum1
Copy link
Contributor

murhum1 commented Apr 19, 2024

I figured it might be better to build the redirect url on server side instead, to avoid extra JS on every page, and for the (unlikely) event where the logout url would change for some reason. Also added the next-parameter to the mobile login link.

Copy link
Contributor

@ihalaij1 ihalaij1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@ihalaij1 ihalaij1 merged commit 8afbc2a into apluslms:master May 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Login should not take the user to the front page
3 participants