Fix issues with multilanguage news #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihalaij1
requested changes
Apr 10, 2024
news/templates/news/list.html
Outdated
| fetch(currentUrl + newsId + '/remove/', { | ||
| method: 'POST', | ||
| headers: { | ||
| 'X-CSRFToken': '{{ csrf_token }}' |
There was a problem hiding this comment.
Could you add a comma after 'X-CSRFToken': '{{ csrf_token }}'?
news/templates/news/list.html
Outdated
Comment on lines
82
to
89
| var removeBtns = document.querySelectorAll("[id^='remove-btn']"); | ||
|
|
||
| for (var i = 0; i < removeBtns.length; i++) { | ||
| removeBtns[i].addEventListener('click', function(event) { | ||
| event.preventDefault(); | ||
|
|
||
| var currentUrl = window.location.href; | ||
| var newsId = this.getAttribute('value'); |
There was a problem hiding this comment.
Only use var if it is needed, I think const and let should be enough in this code.
There was a problem hiding this comment.
Everything is now const except the interator in the for loop which is now let
mikaelGusse
force-pushed
the
master
branch
2 times, most recently
from
2a5ef0c
to
891d200
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What?
Removed two leftover print calls and changed how the singular news remove button functions. Previously the button was sending a GET request which then edited the database which should not be done. This has now been changed such that it send a POST request instead.
Why?
Improves code readability and functionality
How?
Added a javascript listener to the singular remove buttons that then sends the request and redirects back to the current page
Testing
Remember to add or update unit tests for new features and changes.
What type of test did you run?
Tried removing news in different kinds of situations (Just one news item, multiple, last news item, one from the middle etc.)
Did you test the changes in
Think of what is affected by these changes and could become broken
Translation
Programming style
Have you updated the README or other relevant documentation?
Is it Done?
Clean up your git commit history before submitting the pull request!