Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add has_submittable_files to the exercises API endpoint #1357

Merged
merged 1 commit into from
May 7, 2024

Conversation

jaakkonakaza
Copy link
Contributor

Description

What?

Adds the field has_submittable_files to the exercises API, which is true for any exercise that has submittable files and else false.

Why?

Currently each exercise has to be checked separately to see if it is submittable, leading to a lot of unnecessary requests by the IntelliJ plugin. Having the field in the exercises endpoint speeds up loading and reduces requests.

How?

The form_spec in exercise_info is checked to see if any type is file. _generate_data in exercise/cache/basetypes.py does not have type info of exercises, so isinstance(lobj, ExerciseWithAttachment) does not work.

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

@ihalaij1 ihalaij1 self-requested a review May 7, 2024 07:13
@ihalaij1 ihalaij1 self-assigned this May 7, 2024
Copy link
Contributor

@ihalaij1 ihalaij1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I edited the code style a bit to make it cleaner.

@ihalaij1 ihalaij1 merged commit c2fe92a into apluslms:master May 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants