Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix api endpoint for list of points #1372

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

mikaelGusse
Copy link
Contributor

Description

What?

Fix issue where api endpoint GET /courses/<course_id>/points/ was showing the same list as GET /courses/<course_id>/students/. Now endpoint GET /courses/<course_id>/points/ gives the user a list of all students in a course and their points in the course.

Why?

Allows for easier parsing of points for Aalto Grades.

How?

Changed which list is given to the listserializer

Fixes #1360

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

@ihalaij1
Copy link
Contributor

ihalaij1 commented May 28, 2024

Wow!

Interesting find, I wonder if changing the points API to not be the same as the students API will cause issues for some users that currently use the API endpoint...

@ihalaij1 ihalaij1 self-assigned this May 28, 2024
@ihalaij1 ihalaij1 self-requested a review May 28, 2024 06:14
@ihalaij1 ihalaij1 merged commit a3a69f6 into apluslms:master Jun 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

API endpoint for batch fetching student points
2 participants