Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass container on success in #run #20

Merged
merged 1 commit into from
Jan 1, 2014

Conversation

lightsofapollo
Copy link
Contributor

No description provided.

@lightsofapollo
Copy link
Contributor Author

Fixes #20 also fixes some bugs where error callbacks don't return early.

@apocas
Copy link
Owner

apocas commented Jan 1, 2014

Regarding the remove, at the time I left it async mainly for two reasons:
First is that removal isn't really that important for the run objective (think of it like garbage collection done in the 'background')
Second is that container removal in really slow in some scenarios.

But as usual I'm open to opinions, we can't make it another optional specification, there's already many options in run.

What do you think?

@lightsofapollo
Copy link
Contributor Author

I think those are actually good arguments for deleting the temp flag and allowing the caller to deal with removing the container when it makes sense to do so. See #22.

I would consider this PR generally a bugfix so ideally we could land this and discuss removal there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants