Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justification
AtomicU64
has better performance thanArc<Mutex<u64>>
.fetch_add
fits nicely here.last_nonce
doesn't really make sense here, because you get0
just after initializing the client (before you have used any nonce).next_nonce
however breaks the API.Notes
AtomicUsize
is more portable. https://doc.rust-lang.org/stable/std/sync/atomic/index.html#portability