Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dialogues] NPC head animations #65

Closed
Tim-W opened this issue Aug 11, 2015 · 9 comments
Closed

[dialogues] NPC head animations #65

Tim-W opened this issue Aug 11, 2015 · 9 comments
Labels
bug Incorrect or broken functionality request A non-content feature request

Comments

@Tim-W
Copy link

Tim-W commented Aug 11, 2015

NPC head animations do not work on both 377 and 317. When using the dialogue plugin, only a static image of the NPC head is shown.

Should this be fixed plugin-wise or in core?

@Major-
Copy link
Member

Major- commented Aug 11, 2015

Can you provide the code you are using?

@Tim-W
Copy link
Author

Tim-W commented Aug 11, 2015

I've not written any dialogue code, I've just used the built in tutorial island plugin together with the dialogue plugin to test tutorial island. The npc head of the runescape guide wasn't moving in the dialogue.

@WizardJesse1
Copy link
Contributor

there is a packet which apollo does not have for interface animations

@Tim-W
Copy link
Author

Tim-W commented Aug 20, 2015

@WizardJesse1 So... perhaps we should implement the packet?

What's the opcode?

@WizardJesse1
Copy link
Contributor

200 - Animate component
interfaceId - Short
animationId - Short

@Tim-W
Copy link
Author

Tim-W commented Aug 21, 2015

Shouldn't be hard to implement. Would you accept pull requests to implement this @Major- ?

@lare96
Copy link
Contributor

lare96 commented Aug 21, 2015

im sure he wouldn't object to a pull req

@Major-
Copy link
Member

Major- commented Aug 23, 2015

Apollo does have this frame @WizardJesse1 @Tim-W, it's called SetWidgetModelAnimation.

The actual issue is that the emote is never set in any of the dialogues, and that the frame is not sent when the dialogue is. The dialogue code is all cobbled together and needs rewriting in an actual OO manner at some point, so this probably isn't the only issue with them.

@Major- Major- added bug Incorrect or broken functionality request A non-content feature request labels Aug 28, 2015
@rmcmk
Copy link
Contributor

rmcmk commented Jan 24, 2016

I implemented this today, care for a PR? Just so you know, going to need CR as my Ruby is crap.

http://recordit.co/bsMIFshRme

rmcmk added a commit to rmcmk/apollo that referenced this issue Jan 24, 2016
rmcmk added a commit to rmcmk/apollo that referenced this issue Jan 29, 2016
Use block instead of lambda, add emotes.rb

Proper tutorial island emote

Add newline at end of emotes.rb

Use block instead of lambda, fix send_generic_dialogue method to accept block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect or broken functionality request A non-content feature request
Projects
None yet
Development

No branches or pull requests

5 participants