-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dialogues] NPC head animations #65
Comments
Can you provide the code you are using? |
I've not written any dialogue code, I've just used the built in tutorial island plugin together with the dialogue plugin to test tutorial island. The npc head of the runescape guide wasn't moving in the dialogue. |
there is a packet which apollo does not have for interface animations |
@WizardJesse1 So... perhaps we should implement the packet? What's the opcode? |
200 - Animate component |
Shouldn't be hard to implement. Would you accept pull requests to implement this @Major- ? |
im sure he wouldn't object to a pull req |
Apollo does have this frame @WizardJesse1 @Tim-W, it's called SetWidgetModelAnimation. The actual issue is that the emote is never set in any of the dialogues, and that the frame is not sent when the dialogue is. The dialogue code is all cobbled together and needs rewriting in an actual OO manner at some point, so this probably isn't the only issue with them. |
I implemented this today, care for a PR? Just so you know, going to need CR as my Ruby is crap. |
Use block instead of lambda, add emotes.rb Proper tutorial island emote Add newline at end of emotes.rb Use block instead of lambda, fix send_generic_dialogue method to accept block
NPC head animations do not work on both 377 and 317. When using the dialogue plugin, only a static image of the NPC head is shown.
Should this be fixed plugin-wise or in core?
The text was updated successfully, but these errors were encountered: