Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch dependencies to peerDependencies #39

Open
trevor-scheer opened this issue Mar 29, 2023 · 0 comments
Open

Switch dependencies to peerDependencies #39

trevor-scheer opened this issue Mar 29, 2023 · 0 comments

Comments

@trevor-scheer
Copy link
Member

These dependencies should all be installed by the consumer of the package:

    "@apollo/server": "^4.1.1",
    "@azure/functions": "^3.2.0",
    "graphql": "^16.6.0",

Typically the versions we specify for peers are wide. For example, this package will work with all versions of apollo server 4, so we'd specify:

"peerDependencies": {
  "@apollo/server": "^4.0.0",
  ...
}

This is especially critical for graphql, since at runtime it will enforce that there's only one version of it installed. This means that users of this package who install a different version of graphql (like =16.5.0, for example) will encounter runtime errors that they can only work around by specifying your exact version of graphql.

Let me know if you have any questions, happy to help here. This is an important change, so if you don't have the capacity to take this on I'd be happy to. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant