Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple: true to plugin #56

Open
HananeMoshe opened this issue Dec 5, 2023 · 1 comment
Open

Add multiple: true to plugin #56

HananeMoshe opened this issue Dec 5, 2023 · 1 comment

Comments

@HananeMoshe
Copy link

How does the community feel about adding multiple: true to the hapi plugin. I have a few apollo graphql services that add multiple endpoints and need to register the plugin multiple times.

Adding multiple: true here solved the problem and is common in hapi plugins. I am more than happy to create the pr if we are ok with it?

Thank you.

@arimus
Copy link
Collaborator

arimus commented Jan 5, 2024

@HananeMoshe sorry for the late response. I'm not particularly opposed, except that the reason this is usually set to false is so that folks are warned about inadvertent multiple registration issues. We could also provide an alternate entry point or some config to enable this as needed. For your case, you might also be able to just set multiple onto the object before using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants