[Fix]：修复 data race 的问题 #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zouyx
commented
Dec 8, 2020
zouyx
commented
- 修复 data race 的问题
|
感谢您提出Pull Request，我会尽快Review。我会在1-2日内进行查看或者回复，如果遇到节假日可能会处理较慢，敬请谅解。 |
|
@Mergifyio rebase |
|
@Mergifyio update |
Closed
|
Command
|
|
Command
|
zouyx
force-pushed
the
hotfix/fixDataRace
branch
from
16ec602
to
68a4c3a
Compare
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| } | ||
|
|
||
| //SetNextTryConnTime if this connect is fail will set this time | ||
| func SetNextTryConnTime(configIp string, nextPeriod int64) { |
There was a problem hiding this comment.
func parameter configIp should be configIP
| //IsConnectDirectly is connect by ip directly | ||
| //false : yes | ||
| //true : no | ||
| func IsConnectDirectly(configIp string) bool { |
There was a problem hiding this comment.
func parameter configIp should be configIP
| } | ||
|
|
||
| //SetDownNode 设置失效节点 | ||
| func SetDownNode(configIp string, host string) { |
There was a problem hiding this comment.
func parameter configIp should be configIP
| return len(s.serverMap) | ||
| } | ||
|
|
||
| func SetServers(configIp string, serverMap map[string]*config.ServerInfo) { |
There was a problem hiding this comment.
exported function SetServers should have comment or be unexported
func parameter configIp should be configIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.