Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: 修复一些 log 相关的问题 #217

Merged
merged 1 commit into from Mar 20, 2022
Merged

[Fix]: 修复一些 log 相关的问题 #217

merged 1 commit into from Mar 20, 2022

Conversation

zouyx
Copy link
Member

@zouyx zouyx commented Mar 19, 2022

Fixed #211 fix bug about log

@zouyx zouyx self-assigned this Mar 19, 2022
@zouyx zouyx linked an issue Mar 19, 2022 that may be closed by this pull request
@mergify
Copy link
Contributor

mergify bot commented Mar 19, 2022

感谢您提出Pull Request,我会尽快Review。我会在1-2日内进行查看或者回复,如果遇到节假日可能会处理较慢,敬请谅解。

@@ -158,7 +158,7 @@ func Request(requestURL string, connectionConfig *env.ConnectConfig, callBack *C
case http.StatusOK:
responseBody, err := ioutil.ReadAll(res.Body)
if err != nil {
log.Errorf("Connect Apollo Server Fail,url:%s,Error:", requestURL, err)
log.Errorf("Connect Apollo Server Fail,url : %s ,Error: %s ", requestURL, err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
log.Errorf("Connect Apollo Server Fail,url : %s ,Error: %s ", requestURL, err)
log.Errorf("Connect Apollo Server Fail,url: %s, Error: %s", requestURL, err)

@zouyx zouyx merged commit 058afd7 into develop Mar 20, 2022
@zouyx zouyx deleted the feature/fixLog branch March 20, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 日志封装问题
2 participants