Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APOLLO_RUN_MODE 为 Docker 时 应该用 exec 来启动 java 进程 #3458

Merged
merged 1 commit into from Dec 26, 2020
Merged

APOLLO_RUN_MODE 为 Docker 时 应该用 exec 来启动 java 进程 #3458

merged 1 commit into from Dec 26, 2020

Conversation

vdiskg
Copy link
Contributor

@vdiskg vdiskg commented Dec 24, 2020

不使用 exec 启动 java 会让 docker 容器中出现两个进程，bash 进程和 jvm 进程 ，传递给容器的信号将被 bash 进程接收，无法正确传递给 jvm

@Anilople Anilople added area/docker area/adminservice apollo-adminservice area/configservice apollo-configservice area/portal apollo-portal labels Dec 24, 2020
nobodyiam
nobodyiam approved these changes Dec 26, 2020
View reviewed changes
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam added this to the 1.8.0 milestone Dec 26, 2020
@nobodyiam nobodyiam merged commit ad63e14 into apolloconfig:master Dec 26, 2020
@vdiskg vdiskg deleted the docker branch June 27, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobodyiam nobodyiam nobodyiam approved these changes

Assignees
No one assigned
Labels
area/adminservice apollo-adminservice area/configservice apollo-configservice area/docker area/portal apollo-portal
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vdiskg @nobodyiam @Anilople