feat(scripts): use bash to call openapi #3980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3980 +/- ##
============================================
+ Coverage 50.76% 51.11% +0.34%
- Complexity 2468 2482 +14
============================================
Files 475 476 +1
Lines 14600 14681 +81
Branches 1521 1521
============================================
+ Hits 7412 7504 +92
+ Misses 6661 6651 -10
+ Partials 527 526 -1
Continue to review full report at Codecov.
|
|
shall we also update the open api usage document? |
Of course. I will update it later. |
|
and also the CHANGES.md.. |
|
please also update the open api usage document |
Document has already been updated, is there more doc need to be add? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Provide basic functions to call openapi with bash scripts.
User can use it directly without write by self.
Which issue(s) this PR fixes:
Fixes #3941
Brief changelog
file:
.gitattributes: add*.sh text eol=lf, let.shfile end with *nix style line\n.scripts/openapi/bash/openapi.sh: bash functions, user can use them.scripts/openapi/bash/openapi-usage-example.sh: a example to show how to use those bash functions.run
cd scripts/openapi/bash bash -x openapi-usage-example.shto view the result of bash scripts.
In bash scripts, use here document to make json string more readable.
Only cluster's get and create, if it is ok, more functions will be added in the feature.
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.