fix: Fixed overwrite JSON type configuration being empty #4486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jianfei.zhang jianfei.zhang@daocloud.io
Signed-off-by: jianfei.zhang jianfei.zhang@daocloud.io
Signed-off-by: jianfei.zhang <jianfei.zhang@daocloud.io>
Signed-off-by: jianfei.zhang <jianfei.zhang@daocloud.io>
Codecov Report
@@ Coverage Diff @@
## master #4486 +/- ##
=========================================
Coverage 53.63% 53.64%
Complexity 2702 2702
=========================================
Files 489 489
Lines 15294 15294
Branches 1588 1588
=========================================
+ Hits 8203 8204 +1
+ Misses 6535 6534 -1
Partials 556 556
Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
This change seems to bring a new issue: if the user does want to clear the content, it won't work after this fix? |
Yes, let me make a fix |
Signed-off-by: jianfei.zhang <jianfei.zhang@daocloud.io>
falser101
force-pushed
the
fix/json_update
branch
from
0a39af6
to
6897403
Compare
Done. |
falser101
added
bug
nobodyiam
reviewed
Jul 28, 2022
apollo-portal/src/main/resources/static/scripts/directive/namespace-panel-directive.js
Outdated
Show resolved
Hide resolved
Signed-off-by: jianfei.zhang <jianfei.zhang@daocloud.io>
|
Looks good to me, would you please also update the CHANGES.md? |
falser101
changed the title
Signed-off-by: jianfei.zhang <jianfei.zhang@daocloud.io>
Done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
bugfix
Which issue(s) this PR fixes:
Fixes #4483