Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overloaded shortcut method to register BeanDefinition #4574

Merged
merged 4 commits into from Sep 22, 2022
Merged

Add overloaded shortcut method to register BeanDefinition #4574

merged 4 commits into from Sep 22, 2022

Conversation

liaozan
Copy link
Contributor

@liaozan liaozan commented Sep 18, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 18, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@liaozan
Copy link
Contributor Author

liaozan commented Sep 18, 2022

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@mghio mghio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some unit test in BeanRegistrationUtilTest.

@liaozan
Copy link
Contributor Author

liaozan commented Sep 19, 2022

Updated

@codecov-commenter
Copy link

Codecov Report

Merging #4574 (9e8e8fa) into master (78aaca1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #4574      +/-   ##
============================================
+ Coverage     53.45%   53.46%   +0.01%     
- Complexity     2724     2725       +1     
============================================
  Files           495      495              
  Lines         15460    15460              
  Branches       1599     1599              
============================================
+ Hits           8264     8266       +2     
+ Misses         6631     6628       -3     
- Partials        565      566       +1     
Impacted Files Coverage Δ
...spring/spi/DefaultApolloConfigRegistrarHelper.java 75.00% <100.00%> (-0.76%) ⬇️
...i/DefaultConfigPropertySourcesProcessorHelper.java 100.00% <100.00%> (ø)
...ework/apollo/spring/util/BeanRegistrationUtil.java 92.30% <100.00%> (+0.64%) ⬆️
.../framework/apollo/spring/property/SpringValue.java 87.71% <0.00%> (-1.76%) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 77.24% <0.00%> (-1.20%) ⬇️
...ework/apollo/internals/RemoteConfigRepository.java 88.34% <0.00%> (+3.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@mghio mghio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit ba82fec into apolloconfig:master Sep 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants