Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix doc bug #4579

Merged
merged 3 commits into from Oct 25, 2022
Merged

fix doc bug #4579

merged 3 commits into from Oct 25, 2022

Conversation

lepdou
Copy link
Contributor

@lepdou lepdou commented Sep 21, 2022

What's the purpose of this PR

XXXXX

Which issue(s) this PR fixes:

Fixes #

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2022

Codecov Report

Merging #4579 (b63f896) into master (22e6422) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4579   +/-   ##
=========================================
  Coverage     47.24%   47.24%           
  Complexity     1650     1650           
=========================================
  Files           347      347           
  Lines         10631    10631           
  Branches       1053     1053           
=========================================
  Hits           5023     5023           
  Misses         5306     5306           
  Partials        302      302           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@stale
Copy link

stale bot commented Oct 22, 2022

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 14 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale label Oct 22, 2022
@nobodyiam nobodyiam removed the stale label Oct 22, 2022
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 75ae5cc into apolloconfig:master Oct 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants