Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Grayscale release Item Value length limit can not be synchronized… #4622

Merged
merged 1 commit into from Nov 2, 2022

Conversation

David-zhang-beep
Copy link
Contributor

@David-zhang-beep David-zhang-beep commented Nov 1, 2022

I have read the CLA Document and I hereby sign the CLA

fix Grayscale release Item Value length limit can not be synchronized with its main version

What's the purpose of this PR

upgrade the capacity of gray release

Which issue(s) this PR fixes:

Fixes #

Brief changelog

update ItemService.checkItemValueLength() method with logic of find parentNamespace's info.
recheck

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #4622 (6aa7754) into master (3c6baa4) will increase coverage by 0.01%.
The diff coverage is 15.38%.

❗ Current head 6aa7754 differs from pull request most recent head 38f3737. Consider uploading reports for the commit 38f3737 to get more accurate results

@@             Coverage Diff              @@
##             master    #4622      +/-   ##
============================================
+ Coverage     47.20%   47.21%   +0.01%     
- Complexity     1650     1652       +2     
============================================
  Files           347      347              
  Lines         10631    10644      +13     
  Branches       1053     1057       +4     
============================================
+ Hits           5018     5026       +8     
- Misses         5310     5315       +5     
  Partials        303      303              
Impacted Files Coverage Δ
...trip/framework/apollo/biz/service/ItemService.java 34.95% <15.38%> (-2.83%) ⬇️
...framework/apollo/biz/service/NamespaceService.java 64.24% <0.00%> (+0.55%) ⬆️
...mework/apollo/portal/component/PortalSettings.java 65.62% <0.00%> (+7.81%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@David-zhang-beep
Copy link
Contributor Author

recheck

@David-zhang-beep
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 5bec3e4 into apolloconfig:master Nov 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants