Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove app.properties and move some config file's location #4637

Merged
merged 13 commits into from Nov 10, 2022

Conversation

Anilople
Copy link
Contributor

@Anilople Anilople commented Nov 8, 2022

What's the purpose of this PR

try to make config file more simpler.

Which issue(s) this PR fixes:

Fixes #4616 (comment)

Brief changelog

  • remove all app.properties
  • move src/main/config/* to src/main/resources/

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #4637 (1479601) into master (b435050) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4637      +/-   ##
============================================
+ Coverage     47.15%   47.17%   +0.02%     
- Complexity     1648     1650       +2     
============================================
  Files           347      347              
  Lines         10644    10643       -1     
  Branches       1057     1057              
============================================
+ Hits           5019     5021       +2     
+ Misses         5320     5319       -1     
+ Partials        305      303       -2     
Impacted Files Coverage Δ
...apollo/common/controller/ApolloInfoController.java 0.00% <ø> (ø)
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+2.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

nobodyiam
nobodyiam previously approved these changes Nov 9, 2022
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the /apollo/app won't work after app.properties is removed, shall we remove the API?

@RequestMapping("app")
public String getApp() {
return Foundation.app().toString();
}

@Anilople
Copy link
Contributor Author

Anilople commented Nov 9, 2022

I think the /apollo/app won't work after app.properties is removed, shall we remove the API?

@RequestMapping("app")
public String getApp() {
return Foundation.app().toString();
}

Done in commit 1479601

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit dc3067b into apolloconfig:master Nov 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants