Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify url assembly in test cases #4682

Merged
merged 69 commits into from Dec 16, 2022
Merged

Conversation

klboke
Copy link
Contributor

@klboke klboke commented Dec 15, 2022

What's the purpose of this PR

Simplify url assembly in test cases

klboke and others added 30 commits May 16, 2019 11:07
@klboke klboke added the area/test Categorizes issue or PR as related to testing label Dec 15, 2022
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #4682 (5c2b730) into master (d262471) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 5c2b730 differs from pull request most recent head 6a52293. Consider uploading reports for the commit 6a52293 to get more accurate results

@@             Coverage Diff              @@
##             master    #4682      +/-   ##
============================================
+ Coverage     47.15%   47.21%   +0.06%     
- Complexity     1656     1659       +3     
============================================
  Files           349      349              
  Lines         10691    10691              
  Branches       1062     1062              
============================================
+ Hits           5041     5048       +7     
+ Misses         5345     5338       -7     
  Partials        305      305              
Impacted Files Coverage Δ
...ervice/service/ReleaseMessageServiceWithCache.java 85.88% <0.00%> (-1.18%) ⬇️
...mework/apollo/openapi/service/ConsumerService.java 58.46% <0.00%> (+1.53%) ⬆️
...work/apollo/biz/message/ReleaseMessageScanner.java 85.52% <0.00%> (+2.63%) ⬆️
...work/apollo/biz/message/DatabaseMessageSender.java 64.58% <0.00%> (+8.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@Anilople Anilople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 8dd3071 into apolloconfig:master Dec 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
@klboke klboke deleted the test branch March 21, 2023 03:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/test Categorizes issue or PR as related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants