Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ConfigsExportServiceTest support windows #4765

Merged

Conversation

shoothzj
Copy link
Member

@shoothzj shoothzj commented Mar 2, 2023

What's the purpose of this PR

Make ConfigsExportServiceTest support windows.

kezhenxu94
kezhenxu94 previously approved these changes Mar 2, 2023
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also change line 174?

    FileInputStream fileInputStream = new FileInputStream("/tmp/apollo.zip");

@shoothzj
Copy link
Member Author

shoothzj commented Mar 3, 2023

@nobodyiam My fault, fixed.

nobodyiam
nobodyiam previously approved these changes Mar 3, 2023
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #4765 (362a5b8) into master (a76521e) will increase coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4765      +/-   ##
============================================
+ Coverage     47.27%   47.35%   +0.08%     
- Complexity     1655     1657       +2     
============================================
  Files           346      346              
  Lines         10662    10662              
  Branches       1058     1058              
============================================
+ Hits           5040     5049       +9     
+ Misses         5316     5307       -9     
  Partials        306      306              
Impacted Files Coverage Δ
...m/ctrip/framework/apollo/biz/entity/AccessKey.java 58.33% <ø> (ø)
...a/com/ctrip/framework/apollo/biz/entity/Audit.java 52.94% <ø> (ø)
...com/ctrip/framework/apollo/biz/entity/Cluster.java 58.82% <ø> (ø)
.../com/ctrip/framework/apollo/biz/entity/Commit.java 5.55% <ø> (ø)
...p/framework/apollo/biz/entity/GrayReleaseRule.java 100.00% <ø> (ø)
...va/com/ctrip/framework/apollo/biz/entity/Item.java 86.36% <ø> (ø)
...m/ctrip/framework/apollo/biz/entity/Namespace.java 61.11% <ø> (ø)
...rip/framework/apollo/biz/entity/NamespaceLock.java 25.00% <ø> (ø)
...m/ctrip/framework/apollo/biz/entity/Privilege.java 8.33% <ø> (ø)
...com/ctrip/framework/apollo/biz/entity/Release.java 82.14% <ø> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kezhenxu94 kezhenxu94 merged commit e78712b into apolloconfig:master Mar 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2023
@nobodyiam nobodyiam added this to the 2.2.0 milestone Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants