Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: change homepage leftbar font color #4781

Merged
merged 1 commit into from Mar 9, 2023

Conversation

nisiyong
Copy link
Member

@nisiyong nisiyong commented Mar 8, 2023

What's the purpose of this PR

Currently, this font color is a little out of fit. I think make it as same with the button color will be better.
image

image

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #4781 (b797d42) into master (ce1c2f8) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4781      +/-   ##
============================================
+ Coverage     47.26%   47.29%   +0.03%     
- Complexity     1657     1660       +3     
============================================
  Files           346      346              
  Lines         10683    10683              
  Branches       1063     1063              
============================================
+ Hits           5049     5053       +4     
+ Misses         5328     5322       -6     
- Partials        306      308       +2     
Impacted Files Coverage Δ
...mework/apollo/openapi/service/ConsumerService.java 58.46% <0.00%> (+1.53%) ⬆️
...framework/apollo/openapi/entity/ConsumerAudit.java 48.48% <0.00%> (+6.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit d1fb1ed into apolloconfig:master Mar 9, 2023
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2023
@nobodyiam nobodyiam added this to the 2.2.0 milestone Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants