Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the documentation description for "config-service.cache.enabled" #4785

Merged
merged 72 commits into from Mar 10, 2023

Conversation

klboke
Copy link
Contributor

@klboke klboke commented Mar 9, 2023

What's the purpose of this PR

The config-service.cache.enabled configuration adjustment requires a restart of configService to take effect, add this note

klboke and others added 30 commits May 16, 2019 11:07
@klboke klboke requested a review from nobodyiam March 9, 2023 09:27
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #4785 (7dbfa7b) into master (d1fb1ed) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4785      +/-   ##
============================================
- Coverage     47.26%   47.22%   -0.04%     
- Complexity     1657     1659       +2     
============================================
  Files           346      346              
  Lines         10683    10683              
  Branches       1063     1063              
============================================
- Hits           5049     5045       -4     
- Misses         5328     5331       +3     
- Partials        306      307       +1     
Impacted Files Coverage Δ
...oServiceRegistryDeregisterApplicationListener.java 30.00% <0.00%> (-45.00%) ⬇️
...work/apollo/biz/message/ReleaseMessageScanner.java 82.89% <0.00%> (-2.64%) ⬇️
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) ⬆️
...mework/apollo/openapi/service/ConsumerService.java 58.46% <0.00%> (+1.53%) ⬆️
...nfigservice/service/AccessKeyServiceWithCache.java 84.69% <0.00%> (+2.04%) ⬆️
...framework/apollo/openapi/entity/ConsumerAudit.java 48.48% <0.00%> (+6.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit cf99a85 into apolloconfig:master Mar 10, 2023
7 of 8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2023
@klboke klboke deleted the doc branch March 20, 2023 12:43
@nobodyiam nobodyiam added this to the 2.2.0 milestone Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants