Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version notice for other service registry support #4786

Merged
merged 2 commits into from Mar 17, 2023

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

add version notice for other service registry support

Which issue(s) this PR fixes:

Fixes #4779

Brief changelog

add version notice for nacos-discovery/consul-discovery/zookeeper-discovery/custom-defined-discovery respectively.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@nobodyiam nobodyiam requested a review from a team March 10, 2023 00:48
shoothzj
shoothzj previously approved these changes Mar 10, 2023
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #4786 (b42db54) into master (bb15bec) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Current head b42db54 differs from pull request most recent head 92f5a02. Consider uploading reports for the commit 92f5a02 to get more accurate results

@@             Coverage Diff              @@
##             master    #4786      +/-   ##
============================================
- Coverage     47.33%   47.22%   -0.11%     
+ Complexity     1662     1659       -3     
============================================
  Files           346      346              
  Lines         10684    10683       -1     
  Branches       1064     1063       -1     
============================================
- Hits           5057     5045      -12     
- Misses         5319     5331      +12     
+ Partials        308      307       -1     

see 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Anilople Anilople merged commit 1815912 into apolloconfig:master Mar 17, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2023
@nobodyiam nobodyiam deleted the fix-4779 branch March 19, 2023 07:35
@nobodyiam nobodyiam added this to the 2.2.0 milestone Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.7.1版本替换内置Eureka注册中心为nacos没有生效,是不是从1.8.0才支持?
3 participants