Refactor NotFoundException、BadRequestException

[klboke]

What's the purpose of this PR

• Give a unified description to exceptions of the same class

[codecov]

Codecov Report

Merging #4812 (0fe74cf) into master (5903691) will increase coverage by 0.17%.
The diff coverage is 26.42%.

@@             Coverage Diff              @@
##             master    #4812      +/-   ##
============================================
+ Coverage     47.81%   47.98%   +0.17%     
- Complexity     1672     1703      +31     
============================================
  Files           346      346              
  Lines         10665    10694      +29     
  Branches       1065     1066       +1     
============================================
+ Hits           5099     5132      +33     
+ Misses         5251     5246       -5     
- Partials        315      316       +1     

Impacted Files	Coverage Δ
...o/adminservice/aop/NamespaceAcquireLockAspect.java	85.96% <0.00%> (ø)
...apollo/adminservice/aop/NamespaceUnlockAspect.java	81.13% <0.00%> (ø)
...dminservice/controller/AppNamespaceController.java	34.61% <0.00%> (ø)
...llo/adminservice/controller/ClusterController.java	56.00% <0.00%> (ø)
...apollo/adminservice/controller/ItemController.java	42.50% <0.00%> (ø)
...nservice/controller/NamespaceBranchController.java	11.36% <0.00%> (ø)
...o/adminservice/controller/NamespaceController.java	15.62% <0.00%> (ø)
...minservice/controller/NamespaceLockController.java	35.71% <0.00%> (ø)
...llo/adminservice/controller/ReleaseController.java	23.72% <0.00%> (ø)
...framework/apollo/biz/service/AccessKeyService.java	40.00% <0.00%> (ø)
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[nobodyiam]

This is a good try to narrow down the messages. However, there seem 2 patterns to handle the exception:

1. BadRequestException.xxx

throw BadRequestException.itemNotExists(itemId);
throw BadRequestException.namespaceNotExists();

2. new xxxNotFoundException

throw new AppNotFountException(appId);
throw new ClusterNotFoundException(appId, clusterName);

Is there a special consideration for this? Or maybe we could unify them to one pattern?

[klboke]

BadRequestException's HTTP response code is 400, while NotFoundException's HTTP response code is 404.

Is there a special consideration for this? Or maybe we could unify them to one pattern?

Yes, it's unified now.

throw BadRequestException.userNotExists(operator);
throw NotFoundException.itemNotFound(entity.getKey());

[nobodyiam]

LGTM