Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the usage of Env.name() using Env.getName() #4816

Merged
merged 1 commit into from Mar 28, 2023

Conversation

shoothzj
Copy link
Member

What's the purpose of this PR

Rmove the deprecated method, and delete it. If an internal method has been deprecated for a significant period of time, it may be preferable to remove it. If necessary, we can easily restore it using git.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Merging #4816 (66e06ef) into master (8344788) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #4816      +/-   ##
============================================
- Coverage     48.26%   48.26%   -0.01%     
+ Complexity     1722     1721       -1     
============================================
  Files           346      346              
  Lines         10778    10777       -1     
  Branches       1075     1075              
============================================
- Hits           5202     5201       -1     
  Misses         5254     5254              
  Partials        322      322              
Impacted Files Coverage Δ
...k/apollo/portal/component/config/PortalConfig.java 26.66% <0.00%> (ø)
...ework/apollo/portal/controller/ItemController.java 17.77% <0.00%> (ø)
...ctrip/framework/apollo/portal/environment/Env.java 92.64% <ø> (-0.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 3ef13f8 into apolloconfig:master Mar 28, 2023
7 of 9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
@shoothzj shoothzj deleted the remove-the-usage-getname branch March 28, 2023 01:49
@nobodyiam nobodyiam added this to the 2.2.0 milestone Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants