Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename the init.h2.sql to avoid loading wrong files in quick start mode #5034

Merged
merged 1 commit into from Dec 6, 2023

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

rename the init.h2.sql to avoid loading wrong files in quick start mode

Which issue(s) this PR fixes:

Fixes #5033

Brief changelog

add database prefix to the init.h2.sql files.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 6, 2023
@nobodyiam nobodyiam mentioned this pull request Dec 6, 2023
2 tasks
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b67db2b) 49.62% compared to head (ed34b97) 49.53%.

Files Patch % Lines
...mework/apollo/biz/service/BizDBPropertySource.java 0.00% 1 Missing ⚠️
.../apollo/portal/service/PortalDBPropertySource.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5034      +/-   ##
============================================
- Coverage     49.62%   49.53%   -0.09%     
+ Complexity     1904     1901       -3     
============================================
  Files           372      372              
  Lines         11559    11559              
  Branches       1127     1127              
============================================
- Hits           5736     5726      -10     
- Misses         5483     5492       +9     
- Partials        340      341       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 6, 2023
@shoothzj shoothzj merged commit c01ac87 into apolloconfig:master Dec 6, 2023
10 of 12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
@nobodyiam nobodyiam deleted the fix-h2-issue branch December 7, 2023 01:32
@nobodyiam nobodyiam added this to the 2.2.0 milestone Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Column "Cluster" not found error when running apollo quick start with h2
2 participants