Spring Boot中使用SpringApplicationRunListener初始化Apollo的PropertySource #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Reorganize the feature to provide the ability to inject apollo configs in Spring Boot bootstrap phase 3. Add more integration tests to cover different scenarios 4. Update apollo-demo to show this apollo bootstrap config feature could be used with @ConditionalOnProperty
Refactor and reorganize
tastypinenut
commented
Jan 30, 2018
| composite.addPropertySource(new ConfigPropertySource(namespace, config)); | ||
| } | ||
|
|
||
| environment.getPropertySources().addFirst(composite); |
There was a problem hiding this comment.
建议放到systemEnvironment之后，方便开发测试时通过系统变量临时更改参数，代码如下：
propertySources.addAfter(StandardEnvironment.SYSTEM_ENVIRONMENT_PROPERTY_SOURCE_NAME, composite);
优先级如下所示：
StubPropertySource {name='servletConfigInitParams'}
StubPropertySource {name='servletContextInitParams'}
MapPropertySource {name='systemProperties'}
SystemEnvironmentPropertySource {name='systemEnvironment'}
CompositePropertySource [name='ApolloPropertySources', propertySources=[ConfigPropertySource {name='application'}]]
RandomValuePropertySource {name='random'}
PropertiesPropertySource {name='applicationConfig: [classpath:/application-local.properties]'}
PropertiesPropertySource {name='applicationConfig: [classpath:/application.properties]'}
MapPropertySource {name='refresh'}
There was a problem hiding this comment.
在apollo中已经把system property放在前面了，所以在spring这里应该不需要了，详见 https://github.com/ctripcorp/apollo/blob/master/apollo-client/src/main/java/com/ctrip/framework/apollo/internals/DefaultConfig.java#L67
system environment我们是考虑用的比较少，所以是放在apollo后面，作为fallback使用
|
@tastypinenut 这个PR的改动之前已经通过 #937 合并到master了，所以这个PR先关闭了~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.