-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove transformed queries #1859
Remove transformed queries #1859
Conversation
ea191f5
to
dd95a04
Compare
Instead of using You can use @DSteve595 is it ok for you ? |
Sounds great. Thank you all for your hard work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have very small comments. Thanks for taking care of this. It definitely keeps the API surface cleaner.
apollo-compiler/src/main/kotlin/com/apollographql/apollo/compiler/GraphQLCompiler.kt
Outdated
Show resolved
Hide resolved
...e-plugin/src/test/groovy/com/apollographql/apollo/gradle/integration/BasicAndroidSpec.groovy
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Btw, is this a breaking change?
I guess it's a breaking change to whoever is relying on transformed queries. It doesn't change anything to the runtime and/or codegen. Overall, I would say users of transformed queries are advanced enough to migrate to operation output but it's definitely worth a mention in the changelog. |
I guess mention in the changelog would be enough. Their build configuration will fail to find the old property. It's a really simple change to fix it. |
Now that #1841 is merged, this PR can be merged.
This PR:
operationOutput.json
contains more dataoperationOutputFile
aRegularFileProperty
instead of aDirectoryProperty
OperationOutput(File)
to transform OperationOutput.json to data structures easier to work with. There an exemple in the integration tests: https://github.com/apollographql/apollo-android/compare/master...martinbonnin:remove-transformed-queries?expand=1#diff-2966339ccc9c3f57b884f0a635458863R12. Would that be ok ?