New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devtools Completely Locking My Browser #28
Comments
I believe I'm seeing similar behaviour. I am not sure if this is related or not, I thought about posting a topic for this but haven't submitted. When I'm using the Apollo dev tools, I see its ram usage increasing over time consistently. I also see it spiking cpu usage for extended periods of time and can't tell why. I left the window up overnight and when I got back to my machine, my react app chrome tab was using 1.5gb ram at that point. I killed the extensions window and it released the memory. I've only started seeing this behaviour with the Apollo dev tools. If I remove apollo dev tools, I never see this behaviour. Not sure if it matters or not but I have the react, redux dev tools and apollo dev tools all installed. This is on windows 10, chrome version Version 57.0.2987.110 (64-bit). |
Same problem here instantly when opening dev-tools and making 2-3 clicks in App. Mac OSX Sierra 10.12.3 Friend also reporting same problem on his Unix system. Any suggestions how to troubleshoot this further? edit Interesting note might be that the App freezes almost completely but the devtools itself is responsive. Other tabs work fine. Using babel, browser-sync and webpack. |
After digging a little deeper, I think this function might be at least part of the issue. It seems like what's happening is that something inside of |
Experiencing (probably) the same problem, only started recently and renders my App unresponsive |
Thanks for filing the issue @cbranch101! I think your assessment is correct. @rrdelaney has volunteered to help out, and is looking into how we can avoid the costly copying. |
Any progress on this? It's still happening on both my PCs |
Still working on it! It's a pretty big part of the devtools and I'm still working on it 🙂 |
Yeah, basically we need to rearchitect how the devtools communicate with the application. Right now it's copying all of the state on an interval and making it do something else is a big effort. We're also getting some interns joining the Apollo team soon and I hope one of them can help write a totally new system :] |
Seems like rather than setting an interval or setting timeout at the beginning of a polling cycle it could setTimeout at the end so at least you get half a second of work done between polls as a stop gap. |
Dunno if my PR will help but it seems like it could alleviate things in the short term: Basically I changed the interval time from 500ms to 5000ms and it seems to help things in my app at least. I bet that given enough watched queries things the updateData will slow down past the 5000ms mark but at least it doesn't happen after just a couple any more. |
Just hit this problem as well. @tnrich's PR could be an easy fix but this sounds potentially even better & might be doable without rearchitecting anything:
|
I just realised this could be something related to live reloading? It seems to happen after I've been making a few edits, potentially there are lots of |
@thomassuckow I've expanded upon your ideas in #53 @cbranch101 I also realized that the same thing was happening in Panel.js
|
Just merged #53 - let's see if it helps 😄 |
@cbranch101 Is this still a problem? |
I believe that this is no longer an issue
…On Wed, Jul 12, 2017, 6:57 PM Ramya Nagarajan ***@***.***> wrote:
@cbranch101 <https://github.com/cbranch101> Is this still a problem?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACmqcTj9zj_ZMCuV4LcadbxQP3sIXdrwks5sNU8vgaJpZM4MwiAs>
.
|
Yep, this fixed it for me, thanks guys! |
On initial load, everything seems to work fine, but after a clicking around a couple of times, I start getting an unending stream of long process warnings for processes taking around 250 ms, about twice a second, which completely locks up the browser tab I have open. Disabling Devtools causes it to go away.
If there's anything strange about our setup that might be triggering this, I'm guessing it's the fact that we're using deeply nested fragments.
Here's an example query.
I don't know if this relevant as well, but we've also been having trouble with
filter
andpropTypes
fromgraphql-anywhere
eating up a lot of CPU as well.The text was updated successfully, but these errors were encountered: