chore: fix broken scrolling #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessbell
commented
Sep 11, 2023
| @@ -8,6 +8,9 @@ | |||
| body { | |||
| overflow: hidden; | |||
| } | |||
| ::-webkit-scrollbar { | |||
There was a problem hiding this comment.
In dark mode, overflow: scroll means white bars in the reserved space for the scroll bars (in FireFox, it respects the mode the browser is in which is visually much nicer as you can see in the screenshot).
It's possible to style the webkit scroll bar, but the APIs between webkit/non-webkit browsers are different. Hiding the scrollbar in webkit browsers is the past of least CSS for now.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When introducing the resizable sidebar, scrolling broke. Fixed and tested in Chrome and FF.