Handle client termination and recreation #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerelmiller
commented
Mar 28, 2024
| InMemoryCache, | ||
| makeReference, | ||
| useQuery, | ||
| } from "@apollo/client"; | ||
| import ColorSchemeGenerator from "./ColorSchemeGenerator"; | ||
| import Favorites from "./Favorites"; | ||
| import ColorLookup from "./ColorLookup"; | ||
| import { GET_SAVED_COLORS } from "./queries"; | ||
| import "./App.css"; | ||
|
|
||
| function App() { |
There was a problem hiding this comment.
To make this testable, I had to move some code around so that I could recreate the client and ensure it was set in context correctly.
Job #134: Bundle Size — 849.63KiB (+0.03%).Warning Bundle contains 5 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #134 report View jerel/fix-client-termination branch activity View project dashboard |
jerelmiller
force-pushed
the
jerel/fix-client-termination
branch
from
1ebdb78
to
11c4734
Compare
alessbell
approved these changes
Mar 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1240
Handles when
client.stopis called and properly disconnects the client instance from devtools and performs some cleanup in the content script. This also makes it possible to track newly created clients after a previous client was terminated.