Include local fields and types in GraphiQL #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinanastos
force-pushed
the
feat/include-local-state-in-graphiql
branch
from
1d87ead
to
3dfb219
Compare
justinanastos
changed the base branch from
master
to
hugh/chang/ac-local-state-changes
This code is already a little confusing. Let's use some clearer variables names.
This will augment GraphiQL's perceived schema. This will remove warnings in the live query editor and will show client-only fields and types in the documentation explorer. This has no effect on field resolution logic. For Apollo Client 2.4.x and below, querying local-only fields will still fail unless you choose to read from the cache.
justinanastos
force-pushed
the
feat/include-local-state-in-graphiql
branch
from
3dfb219
to
126dd59
Compare
justinanastos
changed the base branch from
hugh/chang/ac-local-state-changes
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #172 and #159
Note: I've also tested this with The AC2.5 update (#166); it works as advertised 🙆
This does not allow GraphiQL to differentiate between local and remote fields; they will look the same in the Documentation Explorer.