Skip to content

Commit

Permalink
Merge branch 'main' into release-3.4.
Browse files Browse the repository at this point in the history
  • Loading branch information
benjamn committed May 12, 2021
2 parents ea3a05c + cdb683c commit 8d91995
Show file tree
Hide file tree
Showing 6 changed files with 41 additions and 29 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,13 @@
### Documentation
TBD

## Apollo Client 3.3.18 (not yet released)

### Bug fixes

- Add `"sideEffects": false` to all generated/published `package.json` files, to improve dead code elimination for nested entry points like `@apollo/client/cache`. <br/>
[@benjamn](https://github.com/benjamn) in [#8213](https://github.com/apollographql/apollo-client/pull/8213)

## Apollo Client 3.3.17

### Bug fixes
Expand Down
1 change: 1 addition & 0 deletions config/prepareDist.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ entryPoints.forEach(function buildPackageJson({
main: `${bundleName}.cjs.js`,
module: 'index.js',
types: 'index.d.ts',
sideEffects: false,
}, null, 2) + "\n",
);
});
54 changes: 30 additions & 24 deletions docs/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
},
"dependencies": {
"gatsby": "2.32.11",
"gatsby-theme-apollo-docs": "4.7.3",
"gatsby-theme-apollo-docs": "4.7.4",
"react": "17.0.1",
"react-dom": "17.0.1",
"webpack-virtual-modules": "0.4.2"
Expand Down
2 changes: 1 addition & 1 deletion docs/source/data/fragments.md
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ FeedEntry.fragments = {
};
```

There's nothing special about the naming of `VoteButtons.fragments.entry` or `RepoInfo.fragments.entry`. Any naming convention works as long as you can retrieve a component's fragments given the component.
There's nothing special about the naming of `VoteButtons.fragments.entry` or `EntryInfo.fragments.entry`. Any naming convention works as long as you can retrieve a component's fragments given the component.

### Importing fragments when using Webpack

Expand Down
4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@
"main": "./dist/main.cjs.js",
"module": "./dist/index.js",
"types": "./dist/index.d.ts",
"sideEffects": [
"./dist/cache/inmemory/fixPolyfills.native.js"
],
"sideEffects": false,
"react-native": {
"./dist/cache/inmemory/fixPolyfills.js": "./dist/cache/inmemory/fixPolyfills.native.js"
},
Expand Down

0 comments on commit 8d91995

Please sign in to comment.