Remove type override

Use 'isValidElement' typeguard Change children to any in MockProviderProps Update Changelog.MD
apollographql · Mar 15, 2021 · d2f3036 · d2f3036
1 parent 49b45e3
commit d2f3036
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,9 @@
 - Maintain serial ordering of `asyncMap` mapping function calls, and prevent potential unhandled `Promise` rejection errors. <br/>
   [@benjamn](https://github.com/benjamn) in [#7818](https://github.com/apollographql/apollo-client/pull/7818)
 
+- Remove `children` type override in MockedProviderProps <br />
+  [@kevinperaza](https://github.com/kevinperaza) in [#7833](https://github.com/apollographql/apollo-client/pull/7833)
+
 ## Apollo Client 3.3.11
 
 ### Bug fixes

diff --git a/src/utilities/testing/mocking/MockedProvider.tsx b/src/utilities/testing/mocking/MockedProvider.tsx
@@ -15,7 +15,7 @@ export interface MockedProviderProps<TSerializedCache = {}> {
   cache?: ApolloCache<TSerializedCache>;
   resolvers?: Resolvers;
   childProps?: object;
-  children?: React.ReactElement;
+  children?: any;
   link?: ApolloLink;
 }
 
@@ -57,7 +57,7 @@ export class MockedProvider extends React.Component<
 
   public render() {
     const { children, childProps } = this.props;
-    return children ? (
+    return React.isValidElement(children) ? (
       <ApolloProvider client={this.state.client}>
         {React.cloneElement(React.Children.only(children), { ...childProps })}
       </ApolloProvider>