Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align @defer v1 implementation with latest proposed spec updates #10019

Closed
alessbell opened this issue Aug 18, 2022 · 4 comments
Closed

Align @defer v1 implementation with latest proposed spec updates #10019

alessbell opened this issue Aug 18, 2022 · 4 comments
Assignees
@alessbell
Labels
🧞‍♂️ enhancement 🍳 breaking change

Comments

@alessbell
Copy link
Member

alessbell commented Aug 18, 2022 •
edited by jpvajda
Loading

While @defer support work is in flight (#10018), it has been implemented against a now-outdated version of the proposed spec.

This is a placeholder issue for aligning with the latest implementation (graphql-js PR here graphql/graphql-js#3659, spec edits PR here graphql/graphql-spec#742)
@Geal Geal mentioned this issue Aug 19, 2022
Closed
@jpvajda
Copy link
Contributor

jpvajda commented Aug 19, 2022

See graphql/defer-stream-wg#41

@alessbell alessbell mentioned this issue Aug 20, 2022
Merged
2 tasks
@jpvajda jpvajda changed the title Align @defer implementation with latest proposed spec updates Align @defer v1 implementation with latest proposed spec updates Aug 22, 2022
@jpvajda jpvajda modified the milestone: Release 3.8 Aug 22, 2022
@jpvajda
Copy link
Contributor

jpvajda commented Aug 24, 2022

See graphql/defer-stream-wg#50

@alessbell
Copy link
Member Author

Closing this as done as the latest changes have been incorporated as of c44b38c

@jpvajda
Copy link
Contributor

jpvajda commented Aug 31, 2022

@alessbell thank you! It's likely we'll have another change to consider in the future as the spec evolves and is ratified, but we can create that ticket when the time comes.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alessbell alessbell

Labels
🧞‍♂️ enhancement 🍳 breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpvajda @alessbell