RefetchQueries will only refetch the first query that is called when 2 with same name.

[happylinks]

When there's two active queries in Apollo with the same name, refetchQueries will only refetch the first query that is called.

Intended outcome:
RefetchQueries always refetches the last query when there are more with the same name, not the first.

Actual outcome:
RefetchQueries always refetches the first query called when there are multiple with the same name.

How to reproduce the issue:

https://github.com/happylinks/react-apollo-error-template

I had an issue with publishing it to gh-pages ("Failed to get remote.https://github.com/happylinks/react-apollo-error-template.git.url (task must either be run in a git repository with a configured https://github.com/happylinks/react-apollo-error-template.git remote or must be configured with the "repo" option).
")

Versions

System:
OS: macOS 10.14.1
Binaries:
Node: 10.9.0 - ~/.nvm/versions/node/v10.9.0/bin/node
Yarn: 1.9.4 - ~/.nvm/versions/node/v10.9.0/bin/yarn
npm: 6.4.1 - ~/.nvm/versions/node/v10.9.0/bin/npm
Browsers:
Chrome: 70.0.3538.77
Firefox: 63.0.1
Safari: 12.0.1
npmPackages:
apollo-cache-inmemory: ^1.2.2 => 1.2.2
apollo-client: ^2.3.2 => 2.3.2
apollo-link: ^1.2.2 => 1.2.2
apollo-link-schema: ^1.1.1 => 1.1.1
react-apollo: 2.1.4 => 2.1.4
npmGlobalPackages:
apollo: 1.9.1

[happylinks]

Digging a bit into the code I found this:

apollo-client/packages/apollo-client/src/core/QueryManager.ts

Lines 1194 to 1206 in 905001e

	private refetchQueryByName(queryName: string) {
	const refetchedQueries = this.queryIdsByName[queryName];
	// early return if the query named does not exist (not yet fetched)
	// this used to warn but it may be inteneded behavoir to try and refetch
	// un called queries because they could be on different routes
	if (refetchedQueries === undefined) return;
	return Promise.all(
	refetchedQueries
	.map(id => this.getQuery(id).observableQuery)
	.filter(x => !!x)
	.map((x: ObservableQuery<any>) => x.refetch()),
	);
	}

So it seems that it should refetch all the queries, eventhough they have the same name. This is not what I see happening in my app though 🤔

[pl12133]

This is a great detailed write up, I think you are facing #3540.

[hwillson]

Duplicate of #3540.