Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use graphql-tag as ESM #6074

Closed
abdonrd opened this issue Mar 23, 2020 · 1 comment
Closed

Use graphql-tag as ESM #6074

abdonrd opened this issue Mar 23, 2020 · 1 comment

Comments

@abdonrd
Copy link
Contributor

abdonrd commented Mar 23, 2020

Similar to #5961, but with graphql-tag.

It would be great that Apollo Client uses that instead of the CJS export.
That way, graphql-tag works directly in the browser.

Also owned by you, Apollo GraphQL. Would it be easy to review that package?
I send a proposal here: apollographql/graphql-tag#273
@abdonrd abdonrd mentioned this issue May 29, 2020
Closed
@abdonrd
Copy link
Contributor Author

abdonrd commented Feb 9, 2021

Closed by #7651

@abdonrd abdonrd closed this as completed Feb 9, 2021
benjamn added a commit that referenced this issue May 14, 2021
@benjamn
Remove dependency on fast-json-stable-stringify.
897e36e 
> Note: I am expecting tests to fail for this commit, demonstrating the
importance of using a stable serialization strategy for field arguments.

Although fast-json-stable-stringify has done its job well, it only
provides a "main" field in its package.json file, pointing to a CommonJS
entry point, and does not appear to export any ECMAScript modules.

Thanks to our conversion/abandonment of fast-json-stable-stringify and
other CommonJS-only npm dependencies (zen-observable in #5961 and
graphql-tag in #6074), it should now (after this PR is merged) be
possible to load @apollo/client/core from an ESM-aware CDN like
jsdelivr.net or jspm.io:

  <script type=module
    src="https://cdn.jsdelivr.net/npm/@apollo/client@beta/core/+esm">
  </script>

If you put that script tag in an HTML file, or inject it into the DOM of
any webpage, you will currently see this error:

  Uncaught SyntaxError: The requested module
  '/npm/fast-json-stable-stringify@2.1.0/+esm' does not provide an
  export named 'default'

This list of errors used to be longer, but now the only package left is
fast-json-stable-stringify.

Note that we're loading @apollo/client/core@beta here, not
@apollo/client@beta. The reason @apollo/client itself is not yet
ESM-ready is that react and react-dom are the two remaining
CommonJS-only dependencies, and @apollo/client currently/regrettably
re-exports utilities from @apollo/client/react.

If importing from @apollo/client/core is a burden or feels weird to you,
please know that we are planning to make @apollo/client synonymous with
@apollo/client/core in Apollo Client 4.0, along with making
@apollo/client/react synonymous with the v3 API of @apollo/client,
though of course those will be major breaking changes:
#8190
@benjamn benjamn mentioned this issue May 14, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abdonrd