Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note on how to make a GraphQL server always accept id in a query #62

Closed
stubailo opened this issue Mar 30, 2016 · 1 comment
Closed

Comments

@stubailo
Copy link
Contributor

From @helfer:

"actually, I’ll just write it down here: it’s in execute.js, all the way at the end in getFieldDef. I think we should just return a default id field if it doesn’t exist on the type. That’s also where the __typename stuff gets handled."

Just something to note when we add the functionality to add id and typename to all queries.

@stubailo stubailo added the idea label Mar 30, 2016
@stubailo
Copy link
Contributor Author

After talking with @martijnwalraven, we decided this is probably not a good idea for now, and we should load type information on the client if we want to get IDs.

Alternatively, we could convince the GraphQL team to add IDs to the spec.

jbaxleyiii pushed a commit that referenced this issue Oct 17, 2017
I made this simple prototype app to demonstrate the power of integrating Apollo with Feathers. The readme highlights some of the key features.
jbaxleyiii pushed a commit that referenced this issue Oct 18, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant