Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove children type override #7833

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Remove children type override #7833

merged 1 commit into from
Mar 15, 2021

Conversation

kevinperaza
Copy link
Contributor

Remove children type override and add React.isValidElement to properly cast React.ReactNode to React.ReactElement

Fixes: #7825

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

benjamn
benjamn approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcreighton jcreighton force-pushed the remove-duplicate-children-property branch from 36d6e54 to 9f469fd Compare March 15, 2021 18:54
@kevinperaza
Remove type override
d2f3036 
Use 'isValidElement' typeguard

Change children to any in MockProviderProps

Update Changelog.MD
@jcreighton jcreighton force-pushed the remove-duplicate-children-property branch from 9f469fd to d2f3036 Compare March 15, 2021 18:55
@jcreighton jcreighton merged commit 048f3b1 into apollographql:main Mar 15, 2021
@jcreighton jcreighton mentioned this pull request Mar 15, 2021
Closed
benjamn added a commit that referenced this pull request Mar 15, 2021
@benjamn
Elaborate CHANGELOG.md entry for PR #7833.
92ce90d
This was referenced Mar 15, 2021
Merged
Merged
Closed
Closed
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Merged
Closed
Merged
Closed
Closed
Merged
Merged
This was referenced Mar 16, 2021
Closed
Closed
Merged
Merged
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Merged
@kevinperaza kevinperaza deleted the remove-duplicate-children-property branch April 2, 2021 03:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benjamn benjamn benjamn approved these changes

Assignees
No one assigned
Labels
⚛️ React-related ⛑ TypeScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MockedProvider has incorrect typescript signature
3 participants
@kevinperaza @benjamn @jcreighton