Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApolloError class missing name property #9322

Closed
aaronadamsCA opened this issue Jan 18, 2022 · 0 comments · Fixed by #9323
Closed

ApolloError class missing name property #9322

aaronadamsCA opened this issue Jan 18, 2022 · 0 comments · Fixed by #9323

Comments

@aaronadamsCA
Copy link
Contributor

ApolloError extends Error, but it doesn't have this.name = 'ApolloError', meaning ApolloError objects don't have a name property.

This breaks TypeScript type safety, since Error has a non-optional property name: string. It's also causing Sentry to complain Non-Error exception captured every time it receives an ApolloError object, because it's missing its name, which is what led me to report this.
aaronadamsCA added a commit to aaronadamsCA/apollo-client that referenced this issue Jan 18, 2022
@aaronadamsCA
Add name property to ApolloError
0e30552 
Fixes apollographql#9322
@aaronadamsCA aaronadamsCA mentioned this issue Jan 18, 2022
Merged
2 tasks
brainkim pushed a commit to aaronadamsCA/apollo-client that referenced this issue Jan 20, 2022
@aaronadamsCA @brainkim
Add name property to ApolloError
ae10468 
Fixes apollographql#9322
jerelmiller pushed a commit to aaronadamsCA/apollo-client that referenced this issue Nov 18, 2022
@aaronadamsCA @jerelmiller
Add name property to ApolloError
84998c6 
Fixes apollographql#9322
jerelmiller added a commit that referenced this issue Nov 18, 2022
@aaronadamsCA @brainkim @jerelmiller
Add name property to ApolloError (#9323)
ace4007 
* Add name property to ApolloError

Fixes #9322

* update error snapshots

* Add CHANGELOG entry for #9323

Co-authored-by: Brian Kim <briankimpossible@gmail.com>
Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add name property to ApolloError aaronadamsCA/apollo-client
1 participant
@aaronadamsCA