Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updateQuery docs having incorrect function signature #10002

Merged
merged 3 commits into from
Aug 16, 2022

Conversation

MrDoomBringer
Copy link
Contributor

@MrDoomBringer MrDoomBringer commented Aug 11, 2022

the updateQuery function under queryResults reported an incorrect signature, making it seem like it had two parameters when it really has a single function (with two params) as a parameter.

Closes #9832

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks @MrDoomBringer!

@MrDoomBringer MrDoomBringer merged commit 8d8c192 into main Aug 16, 2022
@MrDoomBringer MrDoomBringer deleted the MrDoomBringer-patch-2 branch September 6, 2022 14:56
@MrDoomBringer MrDoomBringer self-assigned this Sep 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

updateQuery documentation error
2 participants