Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return most recent result diff from useFragment, update test #10030

Merged

Conversation

alessbell
Copy link
Member

@alessbell alessbell commented Aug 23, 2022

This includes the same fix and adapts the tests from #9918 while targeting the release-3.7 branch. The tests use useQuery and the new test fails if the diff in src/react/hooks/useFragment.ts is reverted.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@alessbell alessbell requested a review from benjamn August 23, 2022 18:21
@alessbell alessbell force-pushed the useBackgroundQuery-hook-add-useFragment-tests branch from 9def955 to 593c706 Compare August 23, 2022 18:40
@alessbell alessbell marked this pull request as ready for review August 23, 2022 18:40
@alessbell
Copy link
Member Author

@benjamn the diff here is identical to #9918 with the exception of src/react/hooks/__tests__/useFragment.test.tsx L836 (calling useQuery instead of useBackgroundQuery)

@alessbell alessbell merged commit bd9e50c into release-3.7 Aug 23, 2022
@alessbell alessbell deleted the useBackgroundQuery-hook-add-useFragment-tests branch August 24, 2022 00:36
@alessbell alessbell mentioned this pull request Sep 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants