Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #10045

Merged
merged 3 commits into from
Sep 2, 2022
Merged

Fix typos #10045

merged 3 commits into from
Sep 2, 2022

Conversation

CompuWiser
Copy link
Contributor

@CompuWiser CompuWiser commented Aug 27, 2022 •
edited

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@apollo-cla
Copy link

@CompuWiser: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

1 similar comment
@apollo-cla
Copy link

@CompuWiser: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

MrDoomBringer
MrDoomBringer suggested changes Aug 30, 2022
View reviewed changes
docs/source/api/react/hooks.mdx Outdated Show resolved Hide resolved
@MrDoomBringer MrDoomBringer self-assigned this Aug 30, 2022
@jpvajda
Copy link
Contributor

jpvajda commented Sep 1, 2022

@MrDoomBringer I committed your suggestion, this should be good to go now if you want to approve this change. Thanks for the contribution @CompuWiser! 🙏

MrDoomBringer
MrDoomBringer approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@MrDoomBringer MrDoomBringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CompuWiser and others added 2 commits September 2, 2022 09:13
@CompuWiser @MrDoomBringer
Fix typos
e10b52a
@jpvajda @MrDoomBringer
Update docs/source/api/react/hooks.mdx
2453c3f 
Co-authored-by: Emmanuel S. <emmanuelssr@gmail.com>
@MrDoomBringer
Copy link
Contributor

Thanks for the PR @CompuWiser, and welcome to the repository!

Best,
Emmanuel, Intern :-)

@MrDoomBringer MrDoomBringer merged commit c214219 into apollographql:main Sep 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MrDoomBringer MrDoomBringer MrDoomBringer approved these changes

@StephenBarlow StephenBarlow Awaiting requested review from StephenBarlow

Assignees

@MrDoomBringer MrDoomBringer

Labels
📝 documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CompuWiser @apollo-cla @jpvajda @MrDoomBringer