Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation update for ApolloQueryResult #10055

Merged
merged 3 commits into from
Sep 6, 2022
Merged

Documentation update for ApolloQueryResult #10055

merged 3 commits into from
Sep 6, 2022

Conversation

MrDoomBringer
Copy link
Contributor

Adds some short TypeDoc comments explaining the difference between response.errors and response.error, per this issue:
#8502

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@MrDoomBringer MrDoomBringer marked this pull request as draft August 30, 2022 17:49
@MrDoomBringer MrDoomBringer linked an issue Aug 30, 2022 that may be closed by this pull request
No documentation for the properties of ApolloQueryResult #8502
Closed
@MrDoomBringer MrDoomBringer marked this pull request as ready for review August 30, 2022 17:52
@MrDoomBringer MrDoomBringer self-assigned this Aug 30, 2022
hwillson
hwillson approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @MrDoomBringer!

@MrDoomBringer MrDoomBringer merged commit efaf6cb into main Sep 6, 2022
@MrDoomBringer MrDoomBringer deleted the MrDoomBringer-patch-3 branch September 6, 2022 14:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hwillson hwillson hwillson approved these changes

Assignees

@MrDoomBringer MrDoomBringer

Labels
📝 documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No documentation for the properties of ApolloQueryResult
2 participants
@MrDoomBringer @hwillson