Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update "Using Apollo with TypeScript" with a description of fetchMore and subscribeToMore #10066

Merged
merged 3 commits into from
Sep 7, 2022

Conversation

bignimbus
Copy link
Contributor

Resolves #9946.

This is my first contribution to apollo-client so feedback is welcome!

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@apollo-cla
Copy link

@bignimbus: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@@ -14,7 +14,7 @@ Apollo Client's `useQuery`, `useMutation` and `useSubscription` React hooks are

### `useQuery`

```jsx
```tsx
Copy link
Contributor Author

@bignimbus bignimbus Sep 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated all js(x) fenced code blocks to ts(x) in this document as well

Before After
Screen Shot 2022-09-01 at 4 59 30 PM Screen Shot 2022-09-01 at 4 59 37 PM

Ensures syntax highlighting is accurately annotated
Add brief explanation and examples for the type parameters of
subscribeToMore and fetchMore
@bignimbus bignimbus force-pushed the issue-9946-subscribe-to-more-docs branch from cf814bc to 23e71f3 Compare September 2, 2022 18:53
@bignimbus bignimbus merged commit a5f91c1 into main Sep 7, 2022
@bignimbus bignimbus deleted the issue-9946-subscribe-to-more-docs branch September 7, 2022 02:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants