Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds defer docs #10079

Merged
merged 16 commits into from
Sep 9, 2022
Merged

adds defer docs #10079

merged 16 commits into from
Sep 9, 2022

Conversation

jpvajda
Copy link
Contributor

@jpvajda jpvajda commented Sep 7, 2022

This PR adds the initial preview documentation for the supporting the @defer directive in Apollo Client

@jpvajda jpvajda self-assigned this Sep 7, 2022
@jpvajda
Copy link
Contributor Author

jpvajda commented Sep 7, 2022

@alessbell @bignimbus 👋

@jpvajda jpvajda linked an issue Sep 7, 2022 that may be closed by this pull request
3 tasks
Copy link
Contributor

@StephenBarlow StephenBarlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions!

docs/source/data/defer.mdx Outdated Show resolved Hide resolved
docs/source/data/defer.mdx Outdated Show resolved Hide resolved
docs/source/config.json Outdated Show resolved Hide resolved
docs/source/data/defer.mdx Outdated Show resolved Hide resolved
docs/source/data/defer.mdx Outdated Show resolved Hide resolved
docs/source/data/defer.mdx Outdated Show resolved Hide resolved
docs/source/data/defer.mdx Outdated Show resolved Hide resolved
docs/source/data/defer.mdx Outdated Show resolved Hide resolved
docs/source/data/defer.mdx Outdated Show resolved Hide resolved
docs/source/data/defer.mdx Outdated Show resolved Hide resolved
jpvajda and others added 7 commits September 8, 2022 08:14
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
jpvajda and others added 2 commits September 8, 2022 08:19
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
martinbonnin added a commit to apollographql/apollo-kotlin that referenced this pull request Sep 8, 2022
martinbonnin pushed a commit to apollographql/apollo-kotlin that referenced this pull request Sep 8, 2022
Co-authored-by: Martin Bonnin <martin@mbonnin.net>

add a link to the (upcoming) documentation

update date

Update docs/source/fetching/defer.mdx

Co-authored-by: JV <jvajda@apollographql.com>

Update CHANGELOG.md

Co-authored-by: JV <jvajda@apollographql.com>

Update CHANGELOG.md

Co-authored-by: JV <jvajda@apollographql.com>

Update docs/source/fetching/defer.mdx

Co-authored-by: JV <jvajda@apollographql.com>

trying to make yaml happy

update `@defer` to stage 2 draft and mention empty `hasNext: false` payloads

see #4373

updates from apollographql/apollo-client#10079

fix an instance of Client -> Kotlin
martinbonnin added a commit to apollographql/apollo-kotlin that referenced this pull request Sep 8, 2022
* Prepare changelog and doc for next version

Co-authored-by: Martin Bonnin <martin@mbonnin.net>

add a link to the (upcoming) documentation

update date

Update docs/source/fetching/defer.mdx

Co-authored-by: JV <jvajda@apollographql.com>

Update CHANGELOG.md

Co-authored-by: JV <jvajda@apollographql.com>

Update CHANGELOG.md

Co-authored-by: JV <jvajda@apollographql.com>

Update docs/source/fetching/defer.mdx

Co-authored-by: JV <jvajda@apollographql.com>

trying to make yaml happy

update `@defer` to stage 2 draft and mention empty `hasNext: false` payloads

see #4373

updates from apollographql/apollo-client#10079

fix an instance of Client -> Kotlin

* revert changes to the tests

* update CHANGELOG.md

Co-authored-by: Martin Bonnin <martin@mbonnin.net>
@jpvajda jpvajda dismissed StephenBarlow’s stale review September 9, 2022 01:58

We took care of all the suggestions.

@jpvajda jpvajda merged commit 3124a05 into main Sep 9, 2022
@jpvajda jpvajda deleted the defer-beta-docs branch September 9, 2022 02:03
@jpvajda
Copy link
Contributor Author

jpvajda commented Sep 9, 2022

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@defer documentation
3 participants