Improvements to the hasDirectives utility function
#10082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessbell
approved these changes
Sep 12, 2022
benjamn
force-pushed
the
utilities/hasAnyDirectives-and-hasAllDirectives
branch
from
2812d5e
to
2c854b0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hasDirectivesutility function is ambiguously named, since it behaves as if it was namedhasAnyDirectives, even though one could also imagine wanting to check that all the provided directives are present, which calls for a name likehasAllDirectives. This PR introduces those two helper functions and adds a bunch of unit tests.This PR builds on the optimization of
hasDirectivesthat I began in #10018 with commit 6d3ad04, though it seemed sufficiently unrelated to that PR to be worth separating out into a second PR.