Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up timeout time for batchLink, query and polling tests #10097

Merged
merged 3 commits into from
Sep 15, 2022

Conversation

MrDoomBringer
Copy link
Contributor

I've been noticing some test failures with these tests in particular every so often, and it's looking like they're often just being re-ran until they pass.

The failing tests all rely on timeouts in some way, and manually lowering the timeout duration produces errors consistent with what I've been seeing. As such, I thought I'd bump up the timeouts a little so these tests pass more reliably, while still allowing unreasonably long runs to fail.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjamn benjamn merged commit efc3dce into apollographql:main Sep 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants